feat: checkbox for quickloot accepted items

[bdzicc]

Description

Checkbox for adding to quick loot accepted list in cyclopedia items tab

Behavior

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested

• Skip when Quick Looting Test

1. Manage Loot Containers
2. Select 'Skipped Loot' filter
3. Click 'ADD TO SKIPPED LOOT LIST' button
4. Select an item from cyclopedia list
5. Checkbox 'Skip when Quick Looting' is present

• Loot when Quick Looting Test

1. Manage Loot Containers
2. Select 'Accepted Loot' filter
3. Click 'ADD TO ACCEPTED LOOT LIST' button
4. Select an item from cyclopedia list
5. Checkbox 'Loot when Quick Looting' is present

Test Configuration:

• Server Version: Canary
• Client: OTC Redemption
• Operating System: Windows 10

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[kokekanon]

@bdzicc Thanks for the PR.

when testing I noticed some unwanted behavior in the checkbox, check the pr I did in your repository,
check https://github.com/bdzicc/otclient/pull/1

bdzicc#1

I noticed that you use getText to know if you're currently in skipquick or lootquick, with the function modules.game_quickloot.QuickLoot.data.filter it's easier to determine.

Also, I made an optimization. I found it unnecessary to have two checkboxes stacked on top of each other, so I used a single function. If you look closely in your pr , they are the same.
the only difference is the number, which is modules.game_quickloot.QuickLoot.data.filter

https://github.com/bdzicc/otclient/pull/1

bandicam.2025-02-28.15-36-57-265.mp4

[bdzicc]

@kokekanon I agree, it makes more sense to use the actual filter value to determine which checkbox to display on the cyclopedia screen.

I tried to extract the filter value from the OTUI file and didn't realize that the modules.game_quickloot.QuickLoot.data.filter table already had this information. In hindsight, I should've used the checkbox values directly instead of relying on getText() if going this route.

The idea of a dynamic checkbox is also a good idea. I did notice some issues with the checkbox functionality due to existing logic, and I thought it might require a separate fix PR. But your changes address that as well, which is perfect.

I've tested everything with your changes and works great.

Thanks for the feedback.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud