Skip to content

Cleanup: Prevent errors and warnings in Lua code#1179

Merged
Nottinghster merged 5 commits intoopentibiabr:mainfrom
Nottinghster:main
Jun 2, 2025
Merged

Cleanup: Prevent errors and warnings in Lua code#1179
Nottinghster merged 5 commits intoopentibiabr:mainfrom
Nottinghster:main

Conversation

@Nottinghster
Copy link
Copy Markdown
Contributor

@Nottinghster Nottinghster commented May 28, 2025

1) duplicate code

  • game_bot

image

  • game_prey

image

2) prevent error:

game_screenshot
image

3) fix warning debug mode

failed to load a widget from '/game_playerdeath/deathwindow'. 
failed to load a widget from 'game_healthcircle'. 
WARNING: widget 'widget5237' '/game_quickloot/quickloot.lua:55'was not explicitly destroyed

4) extended view

I made phantom ConsoleTabBar so that it does not interfere with the game_console drag( extended view)
(it used to be difficult to drag)
now:
asdasd

5) dead code game_outfit :

image

6) fix: main panel height

I created a table with the constants, so that the user can customize it.
image

behavior with 1 store botton:

1111

behavior with 2 store botton:
2222222

7) type error SpellGroups vs game_cooldown

these 3 cooldowns did not work,
image
if you want to reproduce the bug quickly use this command in terminal

modules.game_cooldown.onSpellGroupCooldown(7,1000)
modules.game_cooldown.onSpellGroupCooldown(8,1000)
modules.game_cooldown.onSpellGroupCooldown(9,1000)

8) Keybind

WARNING: Keybind for [UI: Toggle Fullscreen] is already in use
WARNING: Keybind for [UI: Show/hide FPS / lag indicator] is already in use
WARNING: Keybind for [Dialogs: Open Rule Violation] is already in use

9) Fixes in Shop (Store) about Outfits and History

image

* Removed dead code (Outfit)
* Fixed type error SpellGroups vs game_cooldown
* Fixed Keybind
* And more
@Nottinghster Nottinghster changed the title fix: main panel height Cleanup: Prevent errors and warnings in Lua code May 28, 2025
* Added function addOutfit;
* Fixed entries per page (history);
* Fixed Extras Category
* Added function Game.getMountIdByClientId
@sonarqubecloud
Copy link
Copy Markdown

@mehah mehah requested review from kokekanon and luanluciano93 May 29, 2025 14:29
@Nottinghster Nottinghster removed the request for review from kokekanon May 29, 2025 23:21
@Nottinghster Nottinghster merged commit 0736928 into opentibiabr:main Jun 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants