Cleanup: Prevent errors and warnings in Lua code#1179
Merged
Nottinghster merged 5 commits intoopentibiabr:mainfrom Jun 2, 2025
Merged
Cleanup: Prevent errors and warnings in Lua code#1179Nottinghster merged 5 commits intoopentibiabr:mainfrom
Nottinghster merged 5 commits intoopentibiabr:mainfrom
Conversation
* Removed dead code (Outfit) * Fixed type error SpellGroups vs game_cooldown * Fixed Keybind * And more
* Added function addOutfit; * Fixed entries per page (history); * Fixed Extras Category * Added function Game.getMountIdByClientId
|
luanluciano93
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



1) duplicate code
2) prevent error:
game_screenshot

3) fix warning debug mode
4) extended view
I made phantom ConsoleTabBar so that it does not interfere with the game_console drag( extended view)

(it used to be difficult to drag)
now:
5) dead code game_outfit :
6) fix: main panel height
I created a table with the constants, so that the user can customize it.

behavior with 1 store botton:
behavior with 2 store botton:

7) type error SpellGroups vs game_cooldown
these 3 cooldowns did not work,

if you want to reproduce the bug quickly use this command in terminal
8) Keybind
9) Fixes in Shop (Store) about Outfits and History