transports/webrtc: Implement stream message framing#9
Closed
melekes wants to merge 14 commits intoanton/webrtc-transportfrom
Closed
transports/webrtc: Implement stream message framing#9melekes wants to merge 14 commits intoanton/webrtc-transportfrom
melekes wants to merge 14 commits intoanton/webrtc-transportfrom
Conversation
…brtc-message-framing
With mxinden/specs@865f4f2 the RESET no longer resets both write and read part of a stream, but only the former.
9 tasks
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Nice work so far! Thanks for addressing the comments :)
Are you going to have time to address the tests? Otherwise I can add them.
Owner
Author
Please go ahead |
6 tasks
|
I am going to address the tests by working on libp2p#508. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements mxinden/specs#1 for libp2p#2622.
TODOs:
Don't use message framing during noise handshakeUse message framing during noise handshake (see webrtc/: Add message framing to support half-close and reset of stream mxinden/specs#1)SendNo longer required. See webrtc/: Add message framing to support half-close and reset of stream mxinden/specs#1 (comment).RESET_STREAMwhen receivingSTOP_SENDINGLinks to any relevant issues
Open Questions
Change checklist