Skip to content

Update mocha#228

Merged
MgenGlder merged 1 commit intomasterfrom
mgenglder/update-mocha
Sep 25, 2021
Merged

Update mocha#228
MgenGlder merged 1 commit intomasterfrom
mgenglder/update-mocha

Conversation

@MgenGlder
Copy link
Copy Markdown
Collaborator

@MgenGlder MgenGlder commented Sep 25, 2021

Summary

Background

  • We want any major security issues to be resolved moving forward, our mocha is extremely out of date and has many critical and high vulnerabilities (see issue)- we can fix this quickly with an update to latest on mocha.

Acceptance

  • Make sure that everything still works.

@MgenGlder MgenGlder self-assigned this Sep 25, 2021
@MgenGlder MgenGlder added the dependencies Pull requests that update a dependency file label Sep 25, 2021
@MgenGlder
Copy link
Copy Markdown
Collaborator Author

@fabulousduck going to go ahead and merge this one as well. Tested the npm run test command with your added test and didn't see anything act strangely or unexpectedly. To the moon! 🚀

@MgenGlder MgenGlder merged commit 5e3af88 into master Sep 25, 2021
@MgenGlder MgenGlder linked an issue Sep 25, 2021 that may be closed by this pull request
@MgenGlder MgenGlder linked an issue Sep 25, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Mocha to latest to resolve security vulnerability

1 participant