Heltec V3 screen/LED controls and display#1585
Open
Koreanman01 wants to merge 1 commit intomeshcore-dev:mainfrom
Open
Heltec V3 screen/LED controls and display#1585Koreanman01 wants to merge 1 commit intomeshcore-dev:mainfrom
Koreanman01 wants to merge 1 commit intomeshcore-dev:mainfrom
Conversation
oltaco
suggested changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Thanks for this, brightness control will be a great addition. In future please base all PRs against dev branch, PRs against main branch will not be accepted.
I really think this should be implemented in the main SSD1306 display driver so that all devices with SSD1306 can benefit rather than copying the firmwares into the heltec v3 variant folder and adding the feature there.
It's also probably not appropriate to use EnvironmentSensorManager's getNumSettings(), getSettingName(), getSettingValue(), and setSettingValue() methods for setting the display brightness, I think it would require new CMD_GET/SET and PUSH_ codes for companion firmwares and could be integrated with settings in the on device UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Testing