Skip to content

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Aug 28, 2025

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 28, 2025

OT: In my use case I don't need default-dict. So I wonder if we can make it out of default. Also I'm against using default since users can always opt-in feature they want, but a default bundle can often cause unexpected code and break dev flow.

@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.34%. Comparing base (f38a1eb) to head (6e0be04).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files           9        9           
  Lines        1759     1759           
=======================================
  Hits         1466     1466           
  Misses        293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Performance Report

Merging #132 will not alter performance

Comparing tisonkun:reduce-deps (6e0be04) with main (f38a1eb)

Summary

✅ 12 untouched benchmarks

@messense
Copy link
Owner

Without default dict, a simple cargo add jieba-rs workflow does not work out of box which is not good UX I think?

@messense messense merged commit 942fd27 into messense:main Aug 28, 2025
10 checks passed
@tisonkun
Copy link
Contributor Author

@messense there is a flag --features

Let me see if I can make a proper feature, docs, and methods improvement.

@tisonkun tisonkun deleted the reduce-deps branch August 28, 2025 07:09
@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 24, 2025

@messense since include-flate has an advisory item:

error[unmaintained]: proc-macro-error is unmaintained
    ┌─ /path/to/Cargo.lock:423:1
    │
423 │ proc-macro-error 1.0.4 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected
    │
    ├ ID: RUSTSEC-2024-0370
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0370
    ├ proc-macro-error's maintainer seems to be unreachable, with no commits for 2 years, no releases pushed for 4 years, and no activity on the GitLab repo or response to email.
      
      proc-macro-error also depends on `syn 1.x`, which may be bringing duplicate dependencies into dependant build trees.
      
      ## Possible Alternative(s)
      
      - [manyhow](https://crates.io/crates/manyhow)
      - [proc-macro-error2](https://crates.io/crates/proc-macro-error2)
      - [proc-macro2-diagnostics](https://github.com/SergioBenitez/proc-macro2-diagnostics)
    ├ Announcement: https://gitlab.com/CreepySkeleton/proc-macro-error/-/issues/20
    ├ Solution: No safe upgrade is available!
    ├ proc-macro-error v1.0.4
      └── include-flate-codegen v0.3.1
          └── include-flate v0.3.1
              └── jieba-rs v0.8.1

I wonder if it's possible to release a new version (maybe 0.8.2) with this patch included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants