nits in memory optimizations doc #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1585
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8a5a5b2 with merge base cca50f0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
- Coverage 73.12% 71.04% -2.09%
==========================================
Files 289 289
Lines 14175 14175
==========================================
- Hits 10366 10071 -295
- Misses 3809 4104 +295 ☔ View full report in Codecov by Sentry. |
SalmanMohammadi
approved these changes
Sep 14, 2024
Contributor
SalmanMohammadi
left a comment
SalmanMohammadi
left a comment
There was a problem hiding this comment.
these PRs are hit after hit after hit
ebsmothers
added a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing a couple commands and rewording things slightly in a couple places