Skip to content

Conversation

@ebsmothers
Copy link
Contributor

For datasets with RGBA samples we will error out with shape mismatch since we assume 3 channels elsewhere. This change will convert them to RGB up front

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1678

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0906212 with merge base 645e041 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2024
@RdoubleA RdoubleA merged commit e1c2fec into meta-pytorch:main Sep 25, 2024
@vancoykendall
Copy link
Contributor

@ebsmothers Why don't all non-RGB images get converted? #1975

@ebsmothers
Copy link
Contributor Author

@vancoykendall thanks for raising this. Just commented on the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants