Skip to content

Conversation

@tcapelle
Copy link
Contributor

redirect log_dir to wandb.init(..., dir=log_dir)

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/777

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f3c5fa1 with merge base fef3ed1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
Copy link
Collaborator

@RdoubleA RdoubleA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that a command like tune run lora_finetune_single_device --config llama2/7B_lora_single_device metric_logger=torchtune.utils.metric_logging.WandBLogger log_every_n_steps=1 metric_logger.project=my-project runs without error now?

And please run pytest tests --with-integration as a sanity check :)

project (str): WandB project name
entity (Optional[str]): WandB entity name
group (Optional[str]): WandB group name
log_dir (Optional[str]): WandB log directory
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should explain what's used if this is not specified (or if dir is specified)

@RdoubleA
Copy link
Collaborator

Can you verify that a command like tune run lora_finetune_single_device --config llama2/7B_lora_single_device metric_logger=torchtune.utils.metric_logging.WandBLogger log_every_n_steps=1 metric_logger.project=my-project

verified that this runs successfully

wandb: WARNING Path /tmp/lora_finetune_output/wandb/ wasn't writable, using system temp directory.
wandb: WARNING Path /tmp/lora_finetune_output/wandb/ wasn't writable, using system temp directory

@RdoubleA RdoubleA merged commit da608e6 into meta-pytorch:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants