torchx/runner,cli: add patching support via WorkspaceScheduler#360
Closed
torchx/runner,cli: add patching support via WorkspaceScheduler#360
Conversation
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage 94.61% 94.62%
=======================================
Files 60 61 +1
Lines 3103 3160 +57
=======================================
+ Hits 2936 2990 +54
- Misses 167 170 +3
Continue to review full report at Codecov.
|
d4l3k
force-pushed
the
cli_workspace
branch
2 times, most recently
from
3c41b4e to
d4b8890
Compare
Contributor
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
Contributor
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
d4l3k
added a commit
that referenced
this pull request
Jan 4, 2022
Summary: This adds patching support to the cli and runner. To keep this somewhat isolated from the main APIs there's now a couple of new concepts: * WorkspaceScheduler extends Scheduler and adds a build_workspace_image * WorkspaceRunner extends Runner and adds support for building a workspace image as part of dryrun This makes the cli run command use the WorkspaceRunner instead of the normal Runner for experimentation purposes. Patching is enabled if the cwd contains a .torchxconfig file. Pull Request resolved: #360 Test Plan: $ touch .torchxconfig $ echo "echo foo" > foo.sh $ torchx run --scheduler local_docker utils.sh sh foo.sh torchx 2021-12-10 16:24:19 INFO loaded configs from /home/tristanr/Developer/torchx-proj/.torchxconfig torchx 2021-12-10 16:24:19 INFO building patch images for workspace: file:///home/tristanr/Developer/torchx-proj... torchx 2021-12-10 16:24:21 INFO Pulling container image: sha256:0da419b5accdba18412014ffeafcf782acd53d6522a198ee7cbfb48556f355be (this may take a while) torchx 2021-12-10 16:24:23 WARNING failed to pull image sha256:0da419b5accdba18412014ffeafcf782acd53d6522a198ee7cbfb48556f355be, falling back to local: 404 Client Error for htt p+docker://localhost/v1.41/images/create?tag=0da419b5accdba18412014ffeafcf782acd53d6522a198ee7cbfb48556f355be&fromImage=sha256: Not Found ("pull access denied for sha256, reposi tory does not exist or may require 'docker login': denied: requested access to the resource is denied") local_docker://torchx/sh-g7frzl4q92g2bd torchx 2021-12-10 16:24:24 INFO Waiting for the app to finish... torchx 2021-12-10 16:24:24 INFO Job finished: SUCCEEDED sh/0 foo Reviewed By: kiukchung Differential Revision: D33036468 Pulled By: d4l3k fbshipit-source-id: 790ee5fc784adc0c5a3826b63aed5eb6f4e0817e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33036468 |
Summary: This adds patching support to the cli and runner. To keep this somewhat isolated from the main APIs there's now a couple of new concepts: * WorkspaceScheduler extends Scheduler and adds a build_workspace_image * WorkspaceRunner extends Runner and adds support for building a workspace image as part of dryrun This makes the cli run command use the WorkspaceRunner instead of the normal Runner for experimentation purposes. Patching is enabled if the cwd contains a .torchxconfig file. Pull Request resolved: #360 Test Plan: $ touch .torchxconfig $ echo "echo foo" > foo.sh $ torchx run --scheduler local_docker utils.sh sh foo.sh torchx 2021-12-10 16:24:19 INFO loaded configs from /home/tristanr/Developer/torchx-proj/.torchxconfig torchx 2021-12-10 16:24:19 INFO building patch images for workspace: file:///home/tristanr/Developer/torchx-proj... torchx 2021-12-10 16:24:21 INFO Pulling container image: sha256:0da419b5accdba18412014ffeafcf782acd53d6522a198ee7cbfb48556f355be (this may take a while) torchx 2021-12-10 16:24:23 WARNING failed to pull image sha256:0da419b5accdba18412014ffeafcf782acd53d6522a198ee7cbfb48556f355be, falling back to local: 404 Client Error for htt p+docker://localhost/v1.41/images/create?tag=0da419b5accdba18412014ffeafcf782acd53d6522a198ee7cbfb48556f355be&fromImage=sha256: Not Found ("pull access denied for sha256, reposi tory does not exist or may require 'docker login': denied: requested access to the resource is denied") local_docker://torchx/sh-g7frzl4q92g2bd torchx 2021-12-10 16:24:24 INFO Waiting for the app to finish... torchx 2021-12-10 16:24:24 INFO Job finished: SUCCEEDED sh/0 foo Reviewed By: kiukchung Differential Revision: D33036468 Pulled By: d4l3k fbshipit-source-id: 430f1955ce77ff3a3b1d9b1a5ba5deaebf4f25c2
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33036468 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds patching support to the cli and runner.
To keep this somewhat isolated from the main APIs there's now a couple of new concepts:
This makes the cli run command use the WorkspaceRunner instead of the normal Runner for experimentation purposes.
Patching is enabled if the cwd contains a .torchxconfig file.
Test plan: