Skip to content

fix template feature#118

Merged
MarkSackerberg merged 1 commit intomainfrom
fix/template-clone-stderr
Apr 16, 2026
Merged

fix template feature#118
MarkSackerberg merged 1 commit intomainfrom
fix/template-clone-stderr

Conversation

@MarkSackerberg
Copy link
Copy Markdown
Contributor

  1. template/website.ts + template/program.ts: Removed the if (stderr) this.error(stderr) check. git clone writes progress to stderr, which was incorrectly treated as a failure. Actual clone failures are caught by the catch block (since execAsync rejects on non-zero exit code).
  2. template/website.ts: Fixed the malformed flag key '--template' to template so the CLI renders --template instead of ----template.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bda9cec9-e813-4557-adb1-7e69a7bc7d25

📥 Commits

Reviewing files that changed from the base of the PR and between df5a45d and 9bf1daf.

📒 Files selected for processing (2)
  • src/commands/toolbox/template/program.ts
  • src/commands/toolbox/template/website.ts

Summary by CodeRabbit

  • Refactor
    • Updated template command flag format for improved consistency
    • Simplified error handling in template cloning operations to enhance reliability

Walkthrough

The changes remove stderr error handling from git clone operations in two template command files and update a CLI flag key definition from '--template' to template. Both files now ignore stderr output and unconditionally log success messages after clone completion.

Changes

Cohort / File(s) Summary
Template Command Updates
src/commands/toolbox/template/program.ts, src/commands/toolbox/template/website.ts
Removed stderr error handling from git clone operations. Changed CLI flag key from '--template' to template in website.ts. Applied minor whitespace normalization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix template feature' clearly summarizes the main changes: fixing issues in the template feature (stderr handling and flag formatting).
Description check ✅ Passed The description directly relates to the changeset, explaining the two main fixes: removing stderr error checks and correcting the flag key format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/template-clone-stderr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MarkSackerberg MarkSackerberg merged commit 8488fb0 into main Apr 16, 2026
3 checks passed
@MarkSackerberg MarkSackerberg deleted the fix/template-clone-stderr branch April 16, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants