JSONFormatter: check implemented interface before scalars#37
Open
pschultz wants to merge 1 commit intomgutz:masterfrom
Open
JSONFormatter: check implemented interface before scalars#37pschultz wants to merge 1 commit intomgutz:masterfrom
pschultz wants to merge 1 commit intomgutz:masterfrom
Conversation
fgrosse
approved these changes
Sep 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A type alias for built-in scalar types may implement the fmt.Stringer or json.Marshaler interface. However, the JSONFormatter checked for the scalar type before considering the interfaces, and then used one of the strconv functions to encode the value.
That is a) unexpected and b) doesn't necessarily produce correct JSON, leading to a panic. For instance,
strconv.FormatFloat(math.Inf(1), 'g', -1, 64)encodes to+Inf, not"+Inf".