Basic type-checking with mypy and pyright

[Avasam]

This is the PR that finally makes basic type-checking validation of public methods possible, easing the addition of 3.7+ type annotations.

In its current state, a lot of checks are disabled, and some areas of code are completely ignored. But a handful of critical issues are now checked by GitHub actions and will help prevent some regressions.
A few typing fixes have already been provided where I considered they would be worth over disabling globally.

Once this PR is merged, I can in parallel start:

• Progressively adding type annotations for public methods
• Progressively adding explicit type annotations for public variables that are not fully inferred (like partially unknown container types)
• Progressively turning back on some stricter checks in mypy, pyright
• Validating typing standards using https://github.com/PyCQA/flake8-pyi or https://beta.ruff.rs/docs/rules/#flake8-pyi-pyi

[Avasam]

Is this intended to be public API? If not I'd rename it to NoTranslateSet

[Avasam]

Any should be used sparingly, it's an escape hatch. For instance: When it's impossible to represent a type accurately using the current type system.

In this case, we have no way to represent this type though python code (for now). And I need to pass something to the generic type parameter.

[Avasam]

I'm not sure I understand the test failure here. Maybe an infinite loop/wait that causes it to run for hours until it times out?
Merging other related PRs first will lead to less changes here and make it easier for me to figure out where the issue comes from.
Edit: This has now been resolved

[Avasam]

Any idea where CallTipWindow, dde and pywin32_system32 come from?

[mhammond]

dde is a module - https://github.com/mhammond/pywin32/blob/main/setup.py#L2025
pywin32_system32 is a hack setup.py does to put the DLLs in a place where they aren't technically a package, eg, https://github.com/mhammond/pywin32/blob/main/setup.py#L337-L339
IIRC, CallTipWindow was a part of idle which we hackily reused -

pywin32/Pythonwin/pywin/idle/CallTips.py

Lines 38 to 41 in 4025d76

	def _make_tk_calltip_window(self):
	import CallTipWindow
	return CallTipWindow.CallTip(self.text)

- I doubt it works at all any more.

[Avasam]

I went on a deep dive about CallTipWindow yesterday. It comes from pre-Python 3.6 idlelib code. A lot of other modules have been renamed in Python 3.5. Some even have been merged into other modules way before that. Relevant PRs I found:

• CallTips / CallTipWindow renamed in 3.6: https://github.com/python/cpython/pull/7807/files
• Most modules renamed in 3.5: python/cpython@0d9220e
• AutoIndent (and others) removed in 2.3: python/cpython@3ae4eaa

So yeah, I too doubt this works anymore. Not anything for this PR to do. Not sure what you wanna do with that either. But for now I can at least document why CallTipWindow is not a found module.

[Avasam]

@mhammond All issues have finally been resolved! If you want, you can merge #2175 first. Otherwise merging this will close #2175 too

[mhammond]

Thanks, but I'm seeing many annotations in the github "changed files" view which shouldn't be there, near the end of the PR:

I think we need to get rid of these before it can merge.

[mhammond]

Re "Solve some pyright warnings in changed files" - does this imply that in the future, when other changed files are touched, these same warnings might appear in those files?

[Avasam]

Re "Solve some pyright warnings in changed files" - does this imply that in the future, when other changed files are touched, these same warnings might appear in those files?

If a warning is present in a file that has been modified, yes.
Not that these are warnings, not error. They are meant to say "this needs to be looked at, or fixed eventually (but won't block the PR)". There is currently 471 errors that I have downgraded to warnings in pyrightconfig.json because otherwise the CI wouldn't pass in its current state (and the goal of this PR is to do the minimum so that public type-annotations can be type-checked), but they are valid pyright reports.

As for the fact that they show up as "GitHub annotations", I think I can disable that entirely from what I'm reading. https://github.com/actions/toolkit/blob/master/docs/commands.md#problem-matchers

Edit: Didn't seem to work. If these annoy you, I can turn them to "info" in pyright configs.
Edit 2: Figured it out, no more annotation / comment pollution in files tab.

[Avasam]

As a sidenote before this comes up: Test dependencies should probably be pinned. And even better: written to a requirements file so they can be deduplicated, easy to install, and their download cached by the setup-python action. But no dependency is pinned currently in pywin32. So that's a change I'd propose in a separate follow-up PR.

[Avasam]

@mhammond I think all of your latest concerns have been addressed here.

Btw all of my currently opened PRs are ready for review / hoping for a merge. You can use this query to ignore adodbapi-related ones: https://github.com/mhammond/pywin32/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+author%3AAvasam+NOT+adodbapi

[mhammond]

Thanks!