You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry I didn't mention this in the referenced comment, but I'm fairly luke-warm on this - I really don't see a problem that some people might prefer explicit "r" and some might prefer to specify no args in that case. There can't be any confusion, so I'm really not sure this is actually adding value versus change for change's sake.
No problem! You can close this PR if you'd like and the decision will be documented as such. (I myself prefer being explicit with open)
I do think eventually implementing Flake8/Ruff (honestly Ruff is the go-to at this point, more linting coverage, formatter improvements over black, less checkers, much faster) in the CI at some point is a good idea. And this rule can then be excluded (referencing this conversation). Unlike pyupgrade which is barely configurable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #2100 (comment)
Automated changes ran using
ruff . --select=UP015 --exclude=Pythonwin/Scintilla --fix(Ruff re-implements pyupgrade and is configurable)https://docs.astral.sh/ruff/rules/redundant-open-modes/