Update Python2 print commands left in comments and docs#2128
Merged
mhammond merged 4 commits intomhammond:mainfrom Nov 1, 2023
Merged
Conversation
Avasam
force-pushed
the
Update-Python2-print-commands-left-in-comments-and-docs
branch
from
74ee25d to
5b859ae
Compare
Collaborator
|
Those changes I see in adodbapi are all okay. I have no objection to the PR. |
Avasam
commented
Sep 22, 2023
| # assert retvalues[0] == "Dodsworth", '%s is not "Dodsworth"' % repr(retvalues[0]) | ||
| # assert retvalues[1] == "Anne", '%s is not "Anne"' % repr(retvalues[1]) | ||
| # assert retvalues[2] == "DodsworthAnne", '%s is not "DodsworthAnne"' % repr( | ||
| # retvalues[2] |
Collaborator
Author
There was a problem hiding this comment.
Larger changes like these come from simply uncommenting, fixing the print, running black on the file, re-commenting
…e-Python2-print-commands-left-in-comments-and-docs
…e-Python2-print-commands-left-in-comments-and-docs
…e-Python2-print-commands-left-in-comments-and-docs
Owner
|
Thanks! |
Avasam
deleted the
Update-Python2-print-commands-left-in-comments-and-docs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in #1990 because these are all in comments and documentation. There are no runtime change in this PR.
It's possible some of these change aren't perfectly accurate, but I think any misshap should be easily fixable by whoever needs to uncomment that code.