Add missing Mapi call PyIMsgStore.StoreLogoff#2196
Merged
mhammond merged 3 commits intomhammond:mainfrom Mar 13, 2024
Merged
Conversation
mhammond
requested changes
Mar 12, 2024
Owner
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
This looks great, thanks, but there are a couple of tweaks I think should probably be made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PyIMsgStoreobject is currently missingStoreLogoff- without properly shutting down the message store, session logoff andmapi.MAPIUninitialize()might hang indefinitely.The PR adds the missing call and its related constants.