adodbapi: Make multiline ISC explicit#2265
Closed
Avasam wants to merge 1 commit intomhammond:mainfrom
Closed
Conversation
Collaborator
|
Adding my comment here -- even though the PR has been closed. |
Collaborator
Author
|
On modern Python compiler, the difference performance wise is within margin of error (I'm pretty sure implicit or explicit string literal concatenation are handled the same): However, there's other reasons to not accept this overall stylistic change, as mentioned in #2266 , with which this PR should've been closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2242
@vernondcole Make multiline Implicit String Concatenation explicit to avoid mixing up parameters and concatenation.
Found using
ruff check --select=ISC002and the following config in
ruff.toml: