fix(brotli): better brotli detection heuristics#30
Merged
mholt merged 1 commit intomholt:mainfrom Apr 25, 2025
Merged
Conversation
Brotli annoyingly lacks magic bits/headers making content-sniffing it quite difficult. We now employ multiple heuristics including: - checking for errors reading the first 16 bytes - checking to see if the decompressed data exists in the input stream - reading in chunks of 16 bytes up until 128 bytes have been read, checking for errors that would indicate a corrupt archive (which we can infer is us actually trying to decompress non-brotli data)
mholt
approved these changes
Apr 25, 2025
Owner
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Alright, thanks! Let's give this a shot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brotli annoyingly lacks magic bits/headers making content-sniffing it quite difficult. We now employ multiple heuristics including:
Fixes #29
Also forces update to the latest brotli package commit which includes some relevant fixes as there isn't a new official release tag yet.