feat: walking through dereferenced symlink directory#42
Merged
mholt merged 1 commit intomholt:mainfrom Jun 26, 2025
Merged
Conversation
Signed-off-by: Jakub Wójtowicz <jakub.wojtowic@gmail.com>
sephriot
force-pushed
the
walk-symlink-dir
branch
from
de9c191 to
5416700
Compare
mholt
approved these changes
Jun 23, 2025
Owner
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Sorry for the delay.
Thank you for this -- I haven't tested this myself (I'm not really a heavy symlink user) but let's go with this, and if people have issues with it would you be able to help maintain the patch?
Contributor
Author
|
@mholt sure, I'm up for a long term maintenance |
Contributor
Author
|
@mholt If possible, could you please release a new version of the module once this PR is merged? |
Contributor
Author
|
@mholt Please hit the merge button. I have no sufficient privileges to do so. |
Owner
|
Apologies, I was traveling and out of service for a few days. Thanks for your patience. I will try to tag a release soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that the content of a dereferenced directory symlink is not included in the archive, so I decided to fix it.
How it worked before:
If a symlink pointed to a directory that was not part of the files list, the directory was archived, but the content was not.
How it works now:
Both directory and its content are included in the archive.