feat: unused return value checker#135
Open
rileymichael wants to merge 3 commits intomichaelbull:masterfrom
Open
feat: unused return value checker#135rileymichael wants to merge 3 commits intomichaelbull:masterfrom
rileymichael wants to merge 3 commits intomichaelbull:masterfrom
Conversation
Gradle 9 removed the JvmVendorSpec.IBM_SEMERU constant which breaks all versions < 1.0.0.
rileymichael
commented
Dec 29, 2025
|
|
||
| plugins { | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "0.8.0" | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0" |
Author
There was a problem hiding this comment.
gradle 9 removed a deprecated jvm vendor which broke compatibility with foojay toolchain resolver versions before 1.0.0
rileymichael
force-pushed
the
feat/unused-return-value
branch
from
e50f37d to
d969b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #134 as discussed by enabling the unused return value checker in
fullmode for the entire project and explicitly marking methods where the return value is safe to ignore with@IgnorableReturnValue(onSuccessandonFailure).i've also enabled the return value checker in
checkmode in the example application to validate. here is an example warning (note that there are no warnings in the existing usage):