Error on apply rule 'NotEmpty' for key 'File'

[bvanbleyenbergh]

Error when generating Swagger documentation. Results in wrong and missing tags in request body.

error:

warn:` MicroElements.Swashbuckle.FluentValidation.FluentValidationRules[0]
Error on apply rule 'NotEmpty' for key 'File'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_3(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 141
at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91
warn: MicroElements.Swashbuckle.FluentValidation.FluentValidationRules[0]
Error on apply rule 'NotEmpty' for key 'File'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_3(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 141
at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91
warn: MicroElements.Swashbuckle.FluentValidation.FluentValidationRules[0]
Error on apply rule 'Length' for key 'Name'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_5(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 150
at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91
warn: MicroElements.Swashbuckle.FluentValidation.FluentValidationRules[0]
Error on apply rule 'Length' for key 'Name'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_5(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 150
at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91
warn: MicroElements.Swashbuckle.FluentValidation.FluentValidationRules[0]
Error on apply rule 'NotEmpty' for key 'File'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_3(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 141
at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91
warn: MicroElements.Swashbuckle.FluentValidation.FluentValidationRules[0]
Error on apply rule 'NotEmpty' for key 'File'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_3(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 141
at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91
warn: MicroElements.Swashbuckle.FluentValidation.FluentValidationRules[0]
Error on apply rule 'Length' for key 'Name'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_5(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 150
at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91
warn: MicroElements.Swashbuckle.FluentValidation.FluentValidationRules[0]
Error on apply rule 'Length' for key 'Name'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_5(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 150
at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91

My request object:

public class CreateImageRequest
    {
        public IFormFile File { get; set; }
        public string Name { get; set; }
    }

validator:

public class CreateImageRequestValidator : AbstractValidator<CreateImageRequest>
    {
        public CreateImageRequestValidator()
        {
            RuleFor(_ => _.File).NotEmpty().WithErrorCode(ErrorCode.MustNotBeEmpty.ToString());
            RuleFor(_ => _.File).Must((request, ct) =>
            {
                if ((request?.File?.ContentType == @"image/jpeg") || (request?.File?.ContentType == @"image/png"))
                {
                    return true;
                }
                return false;
            }).WithMessage("Invalid content type").WithErrorCode(ErrorCode.ExpectationNotMet.ToString());
            RuleFor(_ => _.Name).Length(0, 250).WithErrorCode(ErrorCode.IncorrectLength.ToString());
        }
    }

Controller method;

public async Task<IActionResult> CreateProfileImage([FromForm]CreateImageRequest request)
        {
             ...
        }

Parameters in swagger docs: (somehow it's labeled as query parameter and no required tags..)

(edited: added validator class)

[petriashev]

What version of package do you use? What version of swagger?

[bvanbleyenbergh]

Currently using:

<ItemGroup>
    <PackageReference Include="Autofac.Extensions.DependencyInjection" Version="4.3.0" />
    <PackageReference Include="FluentValidation" Version="8.0.100" />
    <PackageReference Include="FluentValidation.AspNetCore" Version="8.0.100" />
    <PackageReference Include="MicroElements.Swashbuckle.FluentValidation" Version="1.1.0" />
    <PackageReference Include="Swashbuckle.AspNetCore" Version="3.0.0" />
    <PackageReference Include="Swashbuckle.AspNetCore.ReDoc" Version="3.0.0" />
     ...
    <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.3.0" />
    <PackageReference Include="Microsoft.AspNetCore.App" />
  </ItemGroup>

[vmayushan]

Also not working for [FromQuery] Request: public Task Get([FromQuery] SampleRequest request)

   
    public class SampleRequest
    {
        public int Offset { get; set; }

        public int Count { get; set; }
    }

and for [FromForm] public Task Put([FromForm] SampleRequest request)

    public class SampleRequest 
    {
        public DateTime OpenDateTime { get; set; }

        public DateTime CloseDateTime { get; set; }
    }

Warning in log:

System.NullReferenceException: Object reference not set to an instance of an object.
   at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.<CreateDefaultRules>b__6_9(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line 172
   at MicroElements.Swashbuckle.FluentValidation.FluentValidationOperationFilter.ApplyInternal(Operation operation, OperationFilterContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationOperationFilter.cs:line 91

Currently using:

FluentValidation 7.2
MicroElements.Swashbuckle.FluentValidation 1.1
Swashbuckle.AspNetCore 3.0

[petriashev]

I cant reproduce it.
See branch https://github.com/micro-elements/MicroElements.Swashbuckle.FluentValidation/tree/bugfix/Issue24

And file:
https://github.com/micro-elements/MicroElements.Swashbuckle.FluentValidation/blob/bugfix/Issue24/samples/SampleWebApi/GithubIssues/Issue24.cs

Can you provide code that reproduce error (zip project or fork with sample file)?

[vmayushan]

Sorry for not replying sooner.
Ok, I will try to make sample project :-)

[petriashev]

Any changes?

[JdDCalixL]

Hi, almost same problem here.
Error on apply rule 'NotEmpty' for key 'Nombre'.
System.NullReferenceException: Object reference not set to an instance of an object.
at MicroElements.Swashbuckle.FluentValidation.FluentValidationRules.<>c.b__6_3(RuleContext context) in /home/travis/build/micro-elements/MicroElements.Swashbuckle.FluentValidation/src/MicroElements.Swashbuckle.FluentValidation/FluentValidationRules.cs:line

for Post[FromBody] the model json does show the ValidationMetadata
but for Post[FromQuery] doesnt.

netcoreapp2.1

any help will be appreciated. thanks

[petriashev]

@JdDCalixL Can you attach sample code?

[petriashev]

closed because no activity