Skip to content

Conversation

@big-cir
Copy link
Contributor

@big-cir big-cir commented Jan 25, 2025

Overview

  1. Made corresponding changes in JettyClientTags and JettyClientKeyValues class
  • Removed special handling for 404 status code in the uri method.
  • Removed special handling for redirection status codes in the uri method.

Related

ISSUE: #5812

@big-cir big-cir force-pushed the jetty-no-more-404-redirection branch from 5ab791f to ab45ca9 Compare January 25, 2025 14:18
@shakuzen shakuzen added instrumentation An issue that is related to instrumenting a component module: jetty12 enhancement A general enhancement labels Jan 27, 2025
@shakuzen shakuzen added this to the 1.15.0-M2 milestone Jan 27, 2025
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. It looks good to me.

@shakuzen shakuzen merged commit 0540899 into micrometer-metrics:main Jan 27, 2025
8 checks passed
@big-cir
Copy link
Contributor Author

big-cir commented Jan 27, 2025

Thank you for the pull request. It looks good to me.

Thank you! I appreciate you reviewing and merging my pull request. I'm glad I could contribute to this project.

@big-cir big-cir deleted the jetty-no-more-404-redirection branch May 24, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A general enhancement instrumentation An issue that is related to instrumenting a component module: jetty12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants