[Android] Custom input behaviour check#4320
Merged
almedina-ms merged 97 commits intoSep 21, 2020
Merged
Conversation
…almedina-ms/InputPrototypeAndroid
* Work in progress * Code complete * Now actually code complete * Fix not all required inputs gathered from ShowCard * Accessibility support * Add aria-required, hide suffix from accessibility * aria-required for Toggle and ChoiceSet * Add sample Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
* Remove validation behaviour from host config * Update namings in hostconfig * Fix build errors
ghost
added
the
|
Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @almedina-ms; Thanks for taking action on your previously stale pull request. Resetting staleness. |
paulcam206
approved these changes
Aug 18, 2020
|
Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @almedina-ms; Thanks for taking action on your previously stale pull request. Resetting staleness. |
shalinijoshi19
approved these changes
Sep 21, 2020
almedina-ms
deleted the
user/almedina-ms/IE_Android_CustomInputBehaviour
branch
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Add classes for validation * Add interfaces for input validation * [UWP] Input Validation Prototype * Second version of validation * Update some stuff * Add minor fixes and ur * Add multitype label support * Fix break * Add support for card elements as labels * Add automation properties * Add fixes for accessibiloty * Add host config support * Fix accessibility for error messages * Add host config options for validation behavior * Modify host config to show enw options * Add files to project * Remove UWP specific code * Remove Android specific code changes * Update test files * [TS] Input validation (microsoft#4197) * Work in progress * Code complete * Now actually code complete * Fix not all required inputs gathered from ShowCard * Accessibility support * Add aria-required, hide suffix from accessibility * aria-required for Toggle and ChoiceSet * Add sample Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Shared model] Update namings in host config (microsoft#4213) * Remove validation behaviour from host config * Update namings in hostconfig * Fix build errors * Fix some test json for bugbash * Fix cards with errors * Update long labels to be loooooooooooooooooooooong * [DevSpec] Updates to input validation spec (microsoft#4190) * Input Validation Spec Documents * Fix casing on broken image links' * Updates to document based on discussions and feedback * Minor formatting change Updated the "Start the documentation site" heading to be at the same level as the rest of the headings * Removing instructions around explicit hexo install * [Security] Bump handlebars in /source/nodejs/adaptivecards (microsoft#3692) * Bump handlebars from 4.1.2 to 4.5.3 in /source/community/reactnative (microsoft#3694) * [UWP] Fix null dereference in Media code path (microsoft#3669) [UWP] Fix null dereference in Media code path * [UWP] Fix RendererRegistration error handling and fix inheritance issue with WholeItemsPanel (microsoft#3710) * updated the doc (microsoft#3706) * updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs * [Accessibility] Fixing some color contrast issues in the website (microsoft#3698) * Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal * Fixes microsoft#3577 ; Fixes microsoft#3576: * Fixing outlook.css since that is the style sheet that is being picked up by default when you hit the explorer page * automatic package.json changes * Fixing color syntax * Site readme updates (microsoft#3699) 1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps * added test to parse and render all sample cards (microsoft#3679) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Remove image comparison from unit tests (microsoft#3724) * [UWP] Remove image comparison from unit tests * Code review feedback * Added MaxActions Limit Check (microsoft#3696) * Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Jwoo/ios telephony update (microsoft#3680) * updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix scrolling behaviour in multiline Input.Text (microsoft#3714) * Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix vertical content alignment for elements in root (microsoft#3716) * [SharedModel] Skip date/time tests outside of Pacific TZ (microsoft#3611) * [SharedModel] Skip date/time tests outside of Pacific TZ Fixes microsoft#3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Create cortana-beta-light.json (microsoft#3729) New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light * Create cortana-beta-dark.json (microsoft#3730) Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> * [Android] Fix to have HH:mm in Input.Time elements (microsoft#3713) * Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file * Fixed microsoft#3741 (microsoft#3743) * Updated Cover FillMode Behavior (microsoft#3725) * Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file * Updated Handling of Preprocessed Text (microsoft#3727) * Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated project file to expose media rendere (microsoft#3726) * iOS new layout scheme (microsoft#3687) * Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated the gradle property to handle error token (microsoft#3742) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * More feedback updates * Add backwards compatibility section * Update to labels spec to reflect the latest discussions * Add an update to the label spec to cover the current state of discussions * Update some open discussion and comments * Update link * Flesh out host config options * Fix some comments * Fix more comments * Split original spec into two options * Fix comment from discussion * Get the general spec on track with the other two * Add almost final version * Move costing outside of appendix * Add index to point to topics easier * Add table of contents for validation * Add WCA Guidelines * Add requirements * Update specs * Remove markdown from v1 * Make small updates to input validation spec * Add fixes for comments from last meeting * Update host config structure * Take options out of scope for associated inputs * Add changes from 05/26 meeting * Update requirements * Update last details of spec * [Android] Show all ActionSet's in column (microsoft#4181) * Adjust ActionSet container height to fit contents * Add test card * Fix UWP build break after branch change and merge * Revert no longer relevent changes in samples and schema Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> * [UWP] Input Evolution (microsoft#4088) * Re add everything related to UWP * Remove validation behaviour from host config * Remove references to validation behaviour * Update input retrieval * Add changes to respect label and error messages on custom inputs * Remove comment and repeated code * Update namings in hostconfig * Update host config and fixes broken error message setting * Fix first batch of comments in PR * Remove render context from input value constructor * Fix more comments from PR * Fix more comments * Fix text wrapping in error message and bug in time input validation * Fix input retrieval bug Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Input labels and errors support (microsoft#4039) * First working android version for inputs and errors * Clean up android tests * Fix tests for other input types * Update swig files * Fix build error * Remove validation behaviour from host config * Remove validation behaviour references * Working version n1 for visible views only * Add more changes to respect basic properties as spacing * Add fix to compress casting tasks * Fix some behaviours and check that all inputs work * Update host config * Updsate object model file * Readd legacy card import for testing purposes * Fix android not rendering elements * Fix issues found in bug bash' * Fix test fieks * Fix tests Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix casting issue * Add missing file from previous commit * [WPF] Input Evolution (microsoft#4172) * Add NET shared model support and WPF rendering support for labels and error messages * Fix validation bugs * Fix some acessibility issues Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Fix inline actions not getting inputs (microsoft#4266) * Fix inline actions not validating inputs * Updated specs Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com> * [UWP] Respect host config formatting for labels (microsoft#4289) * Fix host config on labels * Fix comments * Add custom input element to verify correct label rendering * Fix crashes when no input exist in a card (microsoft#4316) * [UWP] Sample custom input (microsoft#4282) * Add sample input and changes the use of internal id for string id * Fix commments from PR * [WPF] Rename the input label host config property to match cpp shared model (microsoft#4308) * Rename the input label host config properties * Remove build files from git * Remove invalid test cards and add new valid test cards * Remove associated inputs from submit actions * Fix failing tests * Fix test errors * Rename custom input to be the same as other renderers (microsoft#4328) * Fix input visibility (microsoft#4306) * Fix crash when clicking inline actin (microsoft#4290) * Fix samples (microsoft#4347) * Remove build files from git * Add properties to hostconfig and fix duplicated id Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [TS] Input accessibility + designer open sample dialog fixes (microsoft#4239) * [JS] Input accessibility and designer fixes * Fix Input.Number min/max not honored when set to 0 * Update package-lock.json * Further package-lock.json updates Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Change async operations to work on a concurrent manner (microsoft#4346) * Ts/input label as label (microsoft#4354) * [JS] Input label as <label> * Fix typo * Update package-lock.json * Another package-lock update * Small preview mode fix Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Android] fix focus on elements (microsoft#4321) * Add custom input element to verify correct label rendering * Fix Focus Visibility on choiceset elements * Add missing file change * Fix build error Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * work in progress * completed input view * completed input label & work in progress for inputvalidation * [UWP] Fix crash when invoking show cards (microsoft#4370) * Remove control validation (microsoft#4379) * [Android] Fix suffix rendering in labels (microsoft#4372) * Remove build files from git * Fix label suffix * [Android] Fix visual input cue to clean the state on instantiation (microsoft#4373) * Remove build files from git * Fix preloaded visual cue * [Android] Fix empty date input (microsoft#4374) * Remove build files from git * Fix date input to allow being empty on start * complted implementing input validation * [JS] Regenerate package-lock files * code complete * Revert "Merge branch 'jwoo/ios-input-evolution' into feature/inputEvolution" This reverts commit 53b529ae363b826784731511a08453006dd5f168, reversing changes made to e1ef301f3babf7c60a9831f2ca5569c544e26c41. * Emit warning for required inputs without label (microsoft#4435) * [UWP] Fix Input.Number validation logic to ensure value is a number (microsoft#4432) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [WPF] Fix automation properties (microsoft#4371) * Remove build files from git * Fix AutomationProperties for Accessibility * Fix comments from pr Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warnings for empty labels in required inputs (microsoft#4409) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warning for empty label in required input (microsoft#4454) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add input retrieval to inlinr submit actions (microsoft#4453) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix stretch textblock claiming all visible space (microsoft#4452) * Fix elements taking the whole space * Add sample files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Sample updates (microsoft#4455) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix PR comments * Change choiceset returns from null to empty (microsoft#4458) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * ios input evolution (microsoft#4437) * refactored and fixed bug bash bugs * fixed merge error * added warning messages when there is no error message is present when the input has the validations * refactored code and fixed unit tests * updated failed test card since bad card is fixed Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Revert files that should not be modified Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: David Claux <dclaux@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Untracked issue
Description
Adds samples for custom inputs to verify that labels are automatically rendered when a custom input element is rendered
How Verified
Microsoft Reviewers: Open in CodeFlow