Merged
Conversation
- Removed duplicate app property from constructor. - Made member variables private. - Changed properties to method so that they can't be replaced and document properly.
rido-min
reviewed
Jul 10, 2025
Contributor
Author
|
I fixed that today
…On Thu, Jul 10, 2025 at 2:59 PM Rido ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
packages/agents-hosting-extensions-teams/test/teams-channel-data-parser/teamsChannelData.test.ts
<#438 (comment)>
:
> @@ -3,6 +3,7 @@ import assert from 'assert'
import { describe, it } from 'node:test'
import { parseTeamsChannelData } from '../../src/activity-extensions/teamsChannelDataParser'
import { ChannelInfo } from '../activity-extensions/channelInfo'
+import { ChannelTypes } from '../activity-extensions/channelTypes'
seems the relative path is wrong, it should be
../../src/activity-extensions
—
Reply to this email directly, view it on GitHub
<#438 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFKUOZMFZDWR7QXUDEUAPT3H3O4RAVCNFSM6AAAAACBFGGEQCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMBXGUZDCOJUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
arocc
suggested changes
Jul 14, 2025
MattB-msft
reviewed
Jul 14, 2025
Co-authored-by: Ashley Rocha <89165999+arocc@users.noreply.github.com>
Co-authored-by: Ashley Rocha <89165999+arocc@users.noreply.github.com>
arocc
reviewed
Jul 18, 2025
arocc
reviewed
Jul 18, 2025
arocc
reviewed
Jul 18, 2025
|
Wanted to see how to move this forward @Stevenic |
…s.ts Co-authored-by: Ashley Rocha <89165999+arocc@users.noreply.github.com>
…s.ts Co-authored-by: Ashley Rocha <89165999+arocc@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates Activity Schema to support new Teams Shared Channels Feature by adding membership source interfaces, enums, and updating activity schemas to handle shared channel scenarios.
- Added
MembershipSourceinterface with related enums (MembershipTypesandMembershipSourceTypes) to track channel membership relationships - Enhanced Teams channel data handling with new properties for shared/unshared teams and membership sources
- Updated channel type definitions to include shared channels and added handlers for channel sharing events
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/agents-activity/src/conversation/membershipSource.ts | New interface and schema for membership source tracking |
| packages/agents-activity/src/conversation/membershipTypes.ts | Enum defining direct vs transitive membership relationships |
| packages/agents-activity/src/conversation/membershipSourceTypes.ts | Enum defining channel vs team membership sources |
| packages/agents-activity/src/conversation/channelAccount.ts | Added optional membershipSources property |
| packages/agents-hosting-extensions-teams/src/activity-extensions/channelTypes.ts | New enum for Teams channel types (standard, private, shared) |
| packages/agents-hosting-extensions-teams/src/activity-extensions/channelInfo.ts | Updated type property to use ChannelTypes enum |
| packages/agents-hosting-extensions-teams/src/activity-extensions/teamsChannelData.ts | Added shared channel properties and membership source handling |
| packages/agents-hosting-extensions-teams/src/teamsAgentExtension.ts | Added handlers for channel shared/unshared events |
| packages/agents-hosting-extensions-teams/test/teams-channel-data-parser/teamsChannelData.test.ts | Updated tests to use ChannelTypes enum |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…icrosoft/Agents-for-js into stevenic/teams-shared-channels
…icrosoft/Agents-for-js into stevenic/teams-shared-channels
rido-min
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Activity Schema to support new Teams Shared Channels Feature
MembershipSourceinterface and Zod schema.ChannelAccountto have a new optionalmembershipSourceproperty.Activityto have a new optionalmembershipSourcesproperty.