Update FICClientId retrieval to use connection-specific environment variable#456
Merged
Update FICClientId retrieval to use connection-specific environment variable#456
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Update retrieval of FICClientId in AuthConfiguration to use connection-specific environment variable instead of the global one
- Changed source loader to fetch FICClientId from
${cnxName}_FICClientId - Updated tests to expect undefined when no connection-specific FICClientId is set
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/agents-hosting/src/auth/authConfiguration.ts | Use connection-specific env var for FICClientId instead of global |
| packages/agents-hosting/test/hosting/authConfiguration.test.ts | Updated expected FICClientId to undefined, reflecting removal of global fallback |
Comments suppressed due to low confidence (3)
packages/agents-hosting/test/hosting/authConfiguration.test.ts:100
- The inline comment is now inaccurate: FICClientId no longer falls back to the global variable. Update it to describe the new behavior, e.g., "// No connection-specific FICClientId set".
assert.strictEqual(config.FICClientId, undefined) // Falls back to global FICClientId
packages/agents-hosting/test/hosting/authConfiguration.test.ts:122
- Add or update an inline comment here to explain why FICClientId is undefined instead of falling back to the global variable.
assert.strictEqual(config.FICClientId, undefined)
packages/agents-hosting/src/auth/authConfiguration.ts:99
- Add a unit test that sets a connection-specific FICClientId environment variable and verifies that
loadAuthConfigFromEnvcorrectly retrieves it.
FICClientId: process.env[`${cnxName}_FICClientId`],
axelsrz
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of the
FICClientIdenvironment variable in theAuthConfigurationmodule to make it connection-specific, aligning it with other configuration properties. Corresponding test cases have been updated to reflect this change.Updates to
AuthConfiguration:packages/agents-hosting/src/auth/authConfiguration.ts: Modified theFICClientIdproperty to use a connection-specific environment variable (${cnxName}_FICClientId) instead of a global one.Updates to tests:
packages/agents-hosting/test/hosting/authConfiguration.test.ts: Updated test cases to expect theFICClientIdproperty to beundefinedwhen the connection-specific environment variable is not set, instead of falling back to the globalFICClientId. [1] [2]