Skip to content

Update FICClientId retrieval to use connection-specific environment variable#456

Merged
rido-min merged 1 commit intomainfrom
fix/fic-named-connection
Jul 15, 2025
Merged

Update FICClientId retrieval to use connection-specific environment variable#456
rido-min merged 1 commit intomainfrom
fix/fic-named-connection

Conversation

@rido-min
Copy link
Copy Markdown
Member

@rido-min rido-min commented Jul 15, 2025

This pull request updates the handling of the FICClientId environment variable in the AuthConfiguration module to make it connection-specific, aligning it with other configuration properties. Corresponding test cases have been updated to reflect this change.

Updates to AuthConfiguration:

Updates to tests:

Copilot AI review requested due to automatic review settings July 15, 2025 00:51
@rido-min rido-min enabled auto-merge (squash) July 15, 2025 00:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Update retrieval of FICClientId in AuthConfiguration to use connection-specific environment variable instead of the global one

  • Changed source loader to fetch FICClientId from ${cnxName}_FICClientId
  • Updated tests to expect undefined when no connection-specific FICClientId is set

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/agents-hosting/src/auth/authConfiguration.ts Use connection-specific env var for FICClientId instead of global
packages/agents-hosting/test/hosting/authConfiguration.test.ts Updated expected FICClientId to undefined, reflecting removal of global fallback
Comments suppressed due to low confidence (3)

packages/agents-hosting/test/hosting/authConfiguration.test.ts:100

  • The inline comment is now inaccurate: FICClientId no longer falls back to the global variable. Update it to describe the new behavior, e.g., "// No connection-specific FICClientId set".
      assert.strictEqual(config.FICClientId, undefined) // Falls back to global FICClientId

packages/agents-hosting/test/hosting/authConfiguration.test.ts:122

  • Add or update an inline comment here to explain why FICClientId is undefined instead of falling back to the global variable.
      assert.strictEqual(config.FICClientId, undefined)

packages/agents-hosting/src/auth/authConfiguration.ts:99

  • Add a unit test that sets a connection-specific FICClientId environment variable and verifies that loadAuthConfigFromEnv correctly retrieves it.
      FICClientId: process.env[`${cnxName}_FICClientId`],

@rido-min rido-min merged commit cb3ac66 into main Jul 15, 2025
7 checks passed
@rido-min rido-min deleted the fix/fic-named-connection branch July 15, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants