Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors imports for logger module and improves project structure by consolidating logger import paths, updating version handling, and enhancing TypeScript configuration. The changes primarily focus on standardizing module imports for better maintainability and consistency across the codebase.
- Consolidated logger imports to use
@microsoft/agents-activity/loggerinstead of the previous@microsoft/agents-activity/src/loggerpath across 26 files - Updated version management to use static imports instead of dynamic imports for better performance
- Enhanced TypeScript configuration and package exports for improved project structure
Reviewed Changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/agents-activity/package.json | Updated exports field to simplify logger module path from ./src/logger to ./logger |
| packages/agents-hosting/src/*.ts (multiple files) | Updated logger imports to use new consolidated path |
| packages/agents-copilotstudio-client/src/*.ts | Updated logger imports and version handling |
| packages/agents-hosting-express/src/startServer.ts | Changed from dynamic to static version import |
| test-agents//src/.ts | Updated dynamic imports to include .js extensions |
| tsconfig.json files | Added explicit include properties for better TypeScript compilation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…oft/Agents-for-js into fix/docs-activity-exports
…omObject for result assertions
rido-min
commented
Jul 15, 2025
added 5 commits
July 15, 2025 21:25
…vider, OAuth flow, and memory storage
…oken provider, OAuth flow, and memory storage" This reverts commit 5a9376a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to improve module imports, streamline version management, and enhance TypeScript configuration. The most significant changes include consolidating logger imports, simplifying version handling, and updating the TypeScript configuration for better project structure.
Improvements to module imports:
@microsoft/agents-activity/loggerinstead of the previous@microsoft/agents-activity/src/loggerpath across multiple files for consistency and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Version management:
CopilotStudioClientto directly use theversionproperty frompackage.jsoninstead of importing the entire package JSON file. This change simplifies the code and reduces unnecessary imports.package.jsonfiles for version retrieval instartServer. Instead, the version is now statically imported for better performance and clarity. [1] [2]TypeScript configuration:
includeproperty in thetsconfig.jsonfile for theagents-copilotstudio-clientpackage to explicitly include thesrcdirectory andpackage.json, ensuring proper compilation of all necessary files.Package export updates:
exportsfield inpackage.jsonforagents-activityto simplify the path for the logger module, improving usability for consumers of the package.These changes collectively enhance the maintainability, performance, and structure of the codebase.