Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…oft/Agents-for-js into fix/docs-activity-exports
…omObject for result assertions
…vider, OAuth flow, and memory storage
…o fix/clean-logs-blob
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes logging levels across storage and authentication modules by converting informational logs to debug, enhancing log consistency and reducing noise in production.
- Downgrades repetitive storage operation logs to debug.
- Updates OAuth flow and MSAL token provider logs to debug.
- Refines JWT middleware to use debug for payload and key‐fetch logs.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/agents-hosting/src/storage/memoryStorage.ts | Changed logger.info to logger.debug for key read/write/delete logs |
| packages/agents-hosting/src/oauth/oAuthFlow.ts | Updated flow state log from info to debug |
| packages/agents-hosting/src/auth/msalTokenProvider.ts | Downgraded token provider info logs to debug |
| packages/agents-hosting/src/auth/jwt-middleware.ts | Switched JWT decode and fetch logs from info to debug |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sw-joelmut
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across multiple packages to enhance consistency, improve test reliability, and refine logging. The most significant updates include restructuring file exports, improving test assertions, and consolidating logger imports. Below is a categorized summary of the most important changes:
File Export Enhancements
package.jsonfiles across multiple packages (e.g.,agents-activity,agents-hosting,agents-hosting-express) to includepackage.jsonin thefilesarray and added type definitions (types) to theexportsfield. This ensures better compatibility and type support for consumers. [1] [2] [3] [4] [5] [6]Test Improvements
activity.test.tsto useActivity.fromObject()for creating activity objects, ensuring consistency and reliability in test cases. [1] [2] [3] [4] [5] [6] [7] [8]Logger Import Consolidation
@microsoft/agents-activity/src/loggerwith the consolidated@microsoft/agents-activity/loggermodule across various files to simplify and standardize logger usage. [1] [2] [3] [4] [5] [6] [7] [8]Logging Enhancements
blobsStorage.tsto provide better insights into blob operations, such as initialization, reads, and writes. This includes logging container details and blob metadata like size and eTag. [1] [2] [3] [4]Version Handling Updates
copilotStudioClient.tsandstartServer.tsto directly import the version frompackage.jsoninstead of dynamically importing it, improving runtime performance and maintainability. [1] [2]These changes collectively enhance the maintainability, reliability, and usability of the codebase.
This pull request introduces several updates across multiple packages, focusing on improving file exports, refactoring imports for better modularity, and enhancing logging in storage-related modules. Below is a summary of the most important changes grouped by theme:
File Exports and Type Definitions
package.jsonfiles across multiple packages (e.g.,agents-activity,agents-copilotstudio-client,agents-hosting-dialogs, etc.) to includepackage.jsonin thefilesarray and added type definitions (types) to theexportsfield. This ensures proper packaging and type support for consumers. [1] [2] [3] [4] [5]Refactored Imports
debugfrom@microsoft/agents-activity/src/loggerwith@microsoft/agents-activity/loggeracross various files for consistency and modularity. [1] [2] [3] [4] [5]Logging Enhancements in Storage Modules
BlobsStorageclass inagents-hosting-storage-blob, including initialization details and operations like reading and writing blobs. This improves traceability and debugging. [1] [2] [3] [4]Test Updates
activity.test.tsto useActivity.fromObjectfor creating activity objects, improving test readability and alignment with theActivityclass structure. [1] [2] [3] [4] [5] [6] [7] [8]Miscellaneous Improvements
package.jsonfor versioning with direct imports in relevant files, such ascopilotStudioClient.tsandstartServer.ts, to simplify code and improve performance. [1] [2]