Skip to content

Review typedocfx#465

Merged
axelsrz merged 3 commits intomainfrom
fix/api-yamls
Jul 17, 2025
Merged

Review typedocfx#465
axelsrz merged 3 commits intomainfrom
fix/api-yamls

Conversation

@rido-min
Copy link
Copy Markdown
Member

No description provided.

…eration; add debug export to agents-activity index and fix tsconfig formatting in agents-hosting-express
Copilot AI review requested due to automatic review settings July 17, 2025 15:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures TypeScript compilation and documentation generation for individual packages, and exposes a new debugging utility.

  • Added include settings and refined rootDirs in the Express hosting package’s tsconfig.json.
  • Exported debug from the agents-activity logger in its index.ts.
  • Refactored the DocFX script to run type2docfx for each package directory.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/agents-hosting-express/tsconfig.json Added include, restricted rootDirs, and reformatted paths
packages/agents-activity/src/index.ts Exported debug from ./logger
.github/scripts/docfx.sh Loop over each package to run type2docfx
Comments suppressed due to low confidence (1)

packages/agents-hosting-express/tsconfig.json:8

  • Removing test/ from rootDirs may prevent test files from being recognized by the compiler. Ensure that test sources are intentionally excluded or add the test directory back if tests still exist in this package.
    "rootDirs": [

Comment thread packages/agents-hosting-express/tsconfig.json
Comment thread .github/scripts/docfx.sh
@rido-min rido-min requested a review from JimDaly July 17, 2025 17:40
@axelsrz axelsrz enabled auto-merge (squash) July 17, 2025 18:34
@axelsrz axelsrz merged commit 0f89b69 into main Jul 17, 2025
7 checks passed
@axelsrz axelsrz deleted the fix/api-yamls branch July 17, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants