Add request logging to ConnectorClient and UserTokenClient#473
Merged
Add request logging to ConnectorClient and UserTokenClient#473
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive HTTP request and response logging capabilities to the ConnectorClient and UserTokenClient classes to improve debugging and traceability. The implementation includes proper handling of sensitive data by excluding authorization headers from logs.
- Added request interceptors to both clients for logging HTTP request details
- Enhanced response logging in
UserTokenClientwith headers and improved error handling - Implemented security-conscious logging by filtering out authorization headers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/agents-hosting/src/connector-client/connectorClient.ts |
Added request interceptor for logging HTTP requests with authorization header filtering |
packages/agents-hosting/src/oauth/userTokenClient.ts |
Added request interceptor, enhanced response logging with headers, and improved error handling with consistent logging |
axelsrz
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhanced logging for HTTP requests and responses in the
ConnectorClientandUserTokenClientclasses by adding request and response interceptors. These changes improve debugging and traceability by logging detailed information about requests and responses, while ensuring sensitive data (e.g., authorization headers) is excluded.Logging Enhancements:
ConnectorClient: Added a request interceptor to log HTTP request details, including method, URL, data, parameters, and headers (excluding authorization headers). (packages/agents-hosting/src/connector-client/connectorClient.ts, packages/agents-hosting/src/connector-client/connectorClient.tsR30-R43)UserTokenClient:ConnectorClient. (packages/agents-hosting/src/oauth/userTokenClient.ts, packages/agents-hosting/src/oauth/userTokenClient.tsL25-L61)packages/agents-hosting/src/oauth/userTokenClient.ts, packages/agents-hosting/src/oauth/userTokenClient.tsL25-L61)