Refactor ConnectorClient methods to remove 'Async' suffix #477
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ConnectorClient class methods by removing the 'Async' suffix from method names to follow JavaScript/TypeScript naming conventions where async methods don't require an explicit 'Async' suffix.
- Renamed 7 ConnectorClient methods to remove 'Async' suffix (e.g.,
replyToActivityAsync→replyToActivity) - Updated all method calls throughout the codebase to use the new naming convention
- Updated test files to mock the renamed methods correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/agents-hosting/src/connector-client/connectorClient.ts | Renamed 7 async methods by removing 'Async' suffix from method names |
| packages/agents-hosting/src/cloudAdapter.ts | Updated all ConnectorClient method calls to use new method names without 'Async' suffix |
| packages/agents-hosting/test/hosting/adapter/cloudAdapter.test.ts | Updated mock method names to match the refactored ConnectorClient methods |
axelsrz
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.