Fix proactive sample#663
Merged
tracyboehrer merged 1 commit intousers/benbro/merge-with-ceciliafrom Oct 15, 2025
Merged
Conversation
tracyboehrer
approved these changes
Oct 15, 2025
tracyboehrer
merged commit bf3a481
into
users/benbro/merge-with-cecilia
2 checks passed
tracyboehrer
added a commit
that referenced
this pull request
Oct 16, 2025
* add baseline support for agentic identity tokens. currently requires a patched msal-node * no more dependency on modified msal * Implement connections and connectionsMap * clean up console.logs, add memory cache * apply linter formatting rules * Use default connection to populate settings * Define constnats for new roles -- see #627 * fix samples * add helper functions for agentic identity * Add descriptions of new fields in channelAccount * Add getTokenProviderFromActivity method * Simplify loadConnections function with object-path package * Simplify loadAuthConfigFromEnv by reusing code * move tenantId to the root of ChannelAccount instead of being only in TeamsChannelAccount * Resolves #629 add APX Scope constants * update function names to match JS style * fix case * Clarify purpose of custom http auth call * lint fix * Fix default connection logic * merged code * move to use dynamic token provider * Adjusted CloudAdapter uploadAttachment/getAttachmentInfo/getAttachment * fixes for agentic with connections manager * Update UserTokenClient to be created per request * update to use symbol key * Remove comments * Remove unused authConfig param * Update verifyToken to use connection settings * Fix lint * ContinueConversation * Cleanup and merge fixes * Lint fixes * [#605] Add Agentic flag to AgentApplication routes (#647) * Add isAgenticRoute flag * Add agentic routes unit tests * Update routes sample * Fix failing test in jwt-middleware.test * Lint fixes * Sample fixes * Lint fix --------- Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * Creating UserTokenClient for process and continueConversation * Removed unused UserTokenClient properties and arguments * Corrected some argument types * start:anon (#653) Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * Fixed UserTokenClient scope (#656) Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * Corrected UserTokenClient endpoint (#660) * Corrected UserTokenClient endpoint * Lint corrections --------- Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * Refactor Authorization flow (#650) * Refactor authorization functionality * Fix some small issues * Fix some issues * fix test * Fix types and add comments * Fix user token client * Fix connections and shared data across handlers * [#603] Rethink how authority and issuers can be customized when not using load** (#661) * Add function to get custom AuthConfig with defaults * Improve function * Fix scope in createUserTokenClient --------- Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> * Remove unused * Add missing param in continueConversation (#663) * Corrected AgentApplication tests (#662) Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * fix cloud adapter tests, fix issue in cloudAdapter where expectReplies was not handled properly (#665) Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> * Lint fixes (#666) Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * More lint fixes (#667) Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * Fix AgentApplication unit tests (#673) * Truncate conversationIds longer than 325 (#668) Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> * Fix turncontext tests (#671) * Fix cloudAdapter linter problems * update syntax for adapter members * Do not start cache purge unless values exist * throw an error if payload of jwt is empty * remove console.log --------- Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> * MemoryCache lint errors (#674) Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * Add OBO connection and scopes (#677) * Add OBO connection and scopes * Fix jsdoc * Add default sign-in text * Fix doc * Use agenticUserId field (#669) * For agentic access token, use agenticUserId field instead of ID field. * Change `username` to `user_id` in agenticUserToken request --------- Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> * Fix some samples (#678) Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> --------- Co-authored-by: CeciliaAvila <cecilia.avila@southworks.com> Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com> Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing parameters in the calls the proactive sample makes to the ContinueConversation method.
Testing
This image shows the sample working on WebChat.
