Back-compat CloudAdapter.createTurnContext#692
Merged
tracyboehrer merged 4 commits intomainfrom Oct 20, 2025
Merged
Conversation
tracyboehrer
requested review from
benbrown and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #687 by making the identity parameter optional in the createTurnContext method of the CloudAdapter class, improving backward compatibility.
- Made the
identityparameter optional inCloudAdapter.createTurnContextmethod
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ceciliaavila
approved these changes
Oct 17, 2025
benbrown
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #687