Skip to content

AAU token for ConnectorClient should use Scope from config#696

Merged
tracyboehrer merged 4 commits intomainfrom
users/tracyboehrer/aau-scope
Oct 20, 2025
Merged

AAU token for ConnectorClient should use Scope from config#696
tracyboehrer merged 4 commits intomainfrom
users/tracyboehrer/aau-scope

Conversation

@tracyboehrer
Copy link
Copy Markdown
Member

Fixes #679

Copilot AI review requested due to automatic review settings October 17, 2025 19:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the authentication configuration to use a configurable scope instead of a hardcoded production scope for AAU token requests in ConnectorClient. The changes allow the scope to be specified through environment variables and configuration settings.

  • Added a configurable scope property to authentication configuration
  • Updated token provider to use the configured scope when available, falling back to the default production scope
  • Added conditional logic to skip user token client creation for agentic requests

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test-agents/agentic-ai/env.TEMPLATE Removed unused agentic connection configuration entries
packages/agents-hosting/src/cloudAdapter.ts Modified to use configurable scope for token requests and skip user token client for agentic requests
packages/agents-hosting/src/auth/authConfiguration.ts Added scope property to AuthConfiguration interface and environment loading functions
.vscode/tasks.json Added build task configuration for agentic-ai test agent
.vscode/launch.json Added launch configuration for agentic-ai test agent

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/agents-hosting/src/cloudAdapter.ts Outdated
@tracyboehrer tracyboehrer requested a review from benbrown October 17, 2025 19:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread packages/agents-hosting/src/cloudAdapter.ts
Copy link
Copy Markdown
Contributor

@benbrown benbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tracyboehrer tracyboehrer merged commit cff41a5 into main Oct 20, 2025
7 checks passed
@tracyboehrer tracyboehrer deleted the users/tracyboehrer/aau-scope branch October 20, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AAU token for ConnectorClient should use Scope from config

3 participants