Fix Consent error for MS Teams + Copilot#888
Merged
sw-joelmut merged 1 commit intomainfrom Jan 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where SSO consent flow fails when using an Agent through M365 Copilot within MS Teams. The issue was that the code only checked if the channelId exactly matched "msteams", but when used through Copilot within Teams, the channelId is actually "msteams:COPILOT" (a composite channel identifier). The fix uses Activity.parseChannelId() to extract the parent channel from composite channel IDs, ensuring the HTTP 412 status code is sent correctly for both regular MS Teams and MS Teams with Copilot scenarios.
Changes:
- Updated
sendInvokeResponsemethod to parse composite channelIds and check the parent channel - Updated the comment to clarify that the method handles both MS Teams and Copilot within MS Teams
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benbrown
approved these changes
Jan 23, 2026
benbrown
pushed a commit
that referenced
this pull request
Jan 28, 2026
Merged
benbrown
added a commit
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #829
Description
This PR fixes an issue where using an Agent through Copilot chat with SSO, when requiring consent flow, it wouldn't let the user sign-in properly. This issue was due to a condition only applied to MS Teams channel specifically, not sending the HTTP 412 status to the channel, so it can retry the consent flow.
Testing
The following image shows the consent card being shown.
