Skip to content

Fix teamsinfo to use adapter.ConnectorClientKey#893

Merged
benbrown merged 3 commits intomainfrom
users/benbro/fix-892
Jan 28, 2026
Merged

Fix teamsinfo to use adapter.ConnectorClientKey#893
benbrown merged 3 commits intomainfrom
users/benbro/fix-892

Conversation

@benbrown
Copy link
Copy Markdown
Contributor

The TeamsInfo object, which is used to make extra calls to Teams API endpoints, needed to be updated to use the new location for the cached ConnectorClient in turncontext.

Changed from turncontext.get('connectorClient') to turncontext.get(turncontext.adapter.ConnectorClientKey)

Copilot AI review requested due to automatic review settings January 27, 2026 17:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the TeamsInfo class to use the new symbolic key (adapter.ConnectorClientKey) for retrieving the cached ConnectorClient from TurnContext, replacing the hardcoded string literal 'connectorClient'. This aligns with the updated architecture where the ConnectorClient is stored using a Symbol key defined in BaseAdapter.

Changes:

  • Updated three locations in teamsInfo.ts to use context.adapter.ConnectorClientKey instead of the string 'connectorClient'
  • Changes maintain backward compatibility with the existing API while aligning with the new internal storage pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/agents-hosting-extensions-teams/src/teamsInfo.ts
Comment thread packages/agents-hosting-extensions-teams/src/teamsInfo.ts
Comment thread packages/agents-hosting-extensions-teams/src/teamsInfo.ts
@benbrown benbrown enabled auto-merge (squash) January 28, 2026 16:24
@benbrown benbrown merged commit b586093 into main Jan 28, 2026
7 checks passed
@benbrown benbrown deleted the users/benbro/fix-892 branch January 28, 2026 16:25
@benbrown benbrown mentioned this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants