Bug fix: Allow whitespace only chunks in streaming response#997
Merged
Bug fix: Allow whitespace only chunks in streaming response#997
Conversation
Previously we were excluding chunks that ailed (!str.trim()) meaning that whitespace only chunks were excluded. This caused issues with markdown, but would also randomly remove characters incorrectly.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes streaming text handling by no longer dropping whitespace-only chunks, which can corrupt Markdown rendering and alter streamed output.
Changes:
- Removes the
!text.trim()early-return guard inqueueTextChunk()so whitespace-only chunks are preserved.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
tracyboehrer
previously approved these changes
Mar 12, 2026
Contributor
…ingResponse (#998) * Initial plan * Add regression tests for whitespace-only chunk preservation in StreamingResponse Co-authored-by: benbrown <729873+benbrown@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: benbrown <729873+benbrown@users.noreply.github.com>
MattB-msft
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were excluding chunks that ailed (!str.trim()) meaning that whitespace only chunks were excluded. This caused issues with markdown, but would also randomly remove characters incorrectly.
Fixes #996