Skip to content

[#989] Improve how empty req.user is handled #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbrown merged 3 commits into from
Mar 13, 2026
Merged

[#989] Improve how empty req.user is handled #999

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac5dafc
Add a warning before using anonymous identity
ceciliaavila Mar 12, 2026
91481f7
Update warning message and method remarks
ceciliaavila Mar 13, 2026
13b54e5
Merge branch 'main' into southworks/add/undefined-user-identity-warning
ceciliaavila Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/agents-hosting/src/cloudAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export class CloudAdapter extends BaseAdapter {
headers?: HeaderPropagationCollection) {
if (!identity?.aud) {
// anonymous
logger.warn('Missing identity or identity.aud when creating connector client. Using anonymous identity')
return ConnectorClient.createClientWithToken(
activity.serviceUrl!,
null!,
Expand Down Expand Up @@ -318,6 +319,10 @@ export class CloudAdapter extends BaseAdapter {
* @param res - The response to send.
* @param logic - The logic to execute.
* @param headerPropagation - Optional function to handle header propagation.
*
* @remarks This function supports both authenticated and unauthenticated requests. When the request is not authenticated,
* the adapter will use anonymous identity. For authenticated requests, the adapter relies on the presence of a user identity
* on `request.user`. It is strongly recommended to use the `authorizeJWT` middleware to ensure that requests are correctly authenticated.
*/
public async process (
request: Request,
Expand Down
Loading