Retarget to roslyn for VS 2022 Update 14#1466
Conversation
e569a91 to
c34bfd6
Compare
This drop support for VS 2019.
c34bfd6 to
3c4aec2
Compare
There was a problem hiding this comment.
FYI, this breaks dotnet build in .NET SDK 8.0.415, so I have to stay with Microsoft.Windows.CsWin32 0.3.205 now.
It would be easier to find a compatible version if any breaking changes like this were listed in release notes.
dotnet/runtime#120815 reminded me about this.
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <!-- These versions carefully chosen to support VS 2019 Update 11. --> | ||
| <!-- These versions carefully chosen to support VS 2022 Update 14. --> |
There was a problem hiding this comment.
The documentation is out of date then:
CsWin32/docfx/docs/getting-started.md
Lines 3 to 5 in b770992
There was a problem hiding this comment.
Thanks for catching this. We should definitely update the 2019 reference.
As for dropping .NET 8 support, ... I wasn't aware it would do that.
@jevansaks I don't remember exactly what prompted this change.... how do you feel about either of us reverting all or part of it?
There was a problem hiding this comment.
I was hitting an issue with assembly version resolution when targeting STJ 9.0.0, but I can put it back and see if I can resolve that a different way.
Updated [Microsoft.Windows.CsWin32](https://github.com/microsoft/CsWin32) from 0.3.205 to 0.3.228. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Windows.CsWin32's releases](https://github.com/microsoft/CsWin32/releases)._ ## 0.3.228 ## What's Changed * BuildTask mode should not generate types from InternalsVisibleTo referenced assemblies by @jevansaks in microsoft/CsWin32#1492 * CsWin32 build task fixes for NET8/CSharp12 by @jevansaks in microsoft/CsWin32#1498 * Fix platform case sensitivity issue with CsWin32Generator tool by @jevansaks in microsoft/CsWin32#1499 * Update documentation for CsWin32RunAsBuildTask mode by @jevansaks in microsoft/CsWin32#1497 * ArrayPool can be larger than requested resulting in freeing uninitialized GCHandles by @jlaanstra in microsoft/CsWin32#1405 * Fix analyzer test break in devdiv AzDO account by @AArnott in microsoft/CsWin32#1504 ## New Contributors * @jlaanstra made their first contribution in microsoft/CsWin32#1405 **Full Changelog**: microsoft/CsWin32@v0.3.217...v0.3.228 https://www.nuget.org/packages/Microsoft.Windows.CsWin32/0.3.228 ## 0.3.217 ## What's Changed * Add cswin32 mode to generate [GeneratedComInterface] and [LibraryImport] code by @jevansaks in microsoft/CsWin32#1474 * Handle UnauthorizedAccessException in new ComTests by @jevansaks in microsoft/CsWin32#1486 * Project byte* parameters as Span<byte> by @jevansaks in microsoft/CsWin32#1488 * Fix nuspec to refer to only signed files and drop apphost.exe from the nuget by @jevansaks in microsoft/CsWin32#1489 **Full Changelog**: microsoft/CsWin32@v0.3.213...v0.3.217 ## 0.3.213 ## What's Changed * Retarget to roslyn for VS 2022 Update 14 by @AArnott in microsoft/CsWin32#1466 * .NET targeting projects should reference `Microsoft.Windows.SDK.NET.Ref` instead by @AArnott in microsoft/CsWin32#1471 * Update win32metadata version to 65.0.8-preview by @jevansaks in microsoft/CsWin32#1469 * Update dependency Microsoft.Build.NoTargets to 3.7.134 by @renovate[bot] in microsoft/CsWin32#1461 **Full Changelog**: microsoft/CsWin32@v0.3.205...v0.3.213 Commits viewable in [compare view](microsoft/CsWin32@v0.3.205...v0.3.228). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.