Conversation
Member
Author
|
There is a test failure in generating |
AArnott
force-pushed
the
fixFullGeneration
branch
2 times, most recently
from
54a4161 to
eea8f9e
Compare
AArnott
force-pushed
the
fixFullGeneration
branch
from
eea8f9e to
a2d686a
Compare
AArnott
added a commit
that referenced
this pull request
Nov 23, 2022
This avoids the crash that has been blocking tests ever since #777 merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our full generation testing was actually omitting many COM interfaces. Closing that hole revealed a few bugs where we can emit C# that will not compile.
These changes address the test hole and the issues that closing it exposed.