Skip to content

Make openmp optional, allow for dylib mac library output#204

Merged
guolinke merged 2 commits intomicrosoft:masterfrom
cbecker:make_openmp_optional
Jan 12, 2017
Merged

Make openmp optional, allow for dylib mac library output#204
guolinke merged 2 commits intomicrosoft:masterfrom
cbecker:make_openmp_optional

Conversation

@cbecker
Copy link
Contributor

@cbecker cbecker commented Jan 12, 2017

This PR allows compiling LightGBM with a compiler that doesn't support OpenMP, which is the case of some clang versions shipped with MacOS. It also adds the CMAKE option to create a dylib library instead of a .so one.

The main change in the C Code is the new header file utils/openmp_wrapper.h

@msftclas
Copy link

Hi @cbecker, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@guolinke guolinke merged commit 300cee5 into microsoft:master Jan 12, 2017
@cbecker cbecker deleted the make_openmp_optional branch January 20, 2017 10:28
@lock lock bot locked as resolved and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants