[R-package] [ci] Fix CI timeouts for Mac builds on Travis (fixes #3091)#3092
Merged
jameslamb merged 10 commits intomicrosoft:masterfrom May 16, 2020
Merged
[R-package] [ci] Fix CI timeouts for Mac builds on Travis (fixes #3091)#3092jameslamb merged 10 commits intomicrosoft:masterfrom
jameslamb merged 10 commits intomicrosoft:masterfrom
Conversation
Collaborator
Author
|
Tested on my fork, the Mac build takes almost 19 minutes but doesn't time out: https://travis-ci.com/github/jameslamb/LightGBM/jobs/335519105 |
guolinke
approved these changes
May 16, 2020
Laurae2
approved these changes
May 16, 2020
StrikerRUS
approved these changes
May 16, 2020
Collaborator
StrikerRUS
left a comment
StrikerRUS
left a comment
There was a problem hiding this comment.
LGTM in general! Thanks!
Left two point for consideration.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
This was referenced May 17, 2020
odimka
pushed a commit
to odimka/LightGBM
that referenced
this pull request
May 17, 2020
…osoft#3091) (microsoft#3092) * [R-package] use processx to speed up builds * different fix * echoing more frequently * fix it * more stdout * use print() instead of message() * shell tricks * fix message * travis * Update .ci/test_r_package.sh Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
ChipKerchner
pushed a commit
to ChipKerchner/LightGBM
that referenced
this pull request
Jun 10, 2020
…osoft#3091) (microsoft#3092) * [R-package] use processx to speed up builds * different fix * echoing more frequently * fix it * more stdout * use print() instead of message() * shell tricks * fix message * travis * Update .ci/test_r_package.sh Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
ChipKerchner
pushed a commit
to ChipKerchner/LightGBM
that referenced
this pull request
Jun 11, 2020
…osoft#3091) (microsoft#3092) * [R-package] use processx to speed up builds * different fix * echoing more frequently * fix it * more stdout * use print() instead of message() * shell tricks * fix message * travis * Update .ci/test_r_package.sh Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3091 for details. This PR fixes the recent issues with R Mac builds timing out on Travis.
It's not clear why these builds, which used to take around 10 minutes total, now take closer to 19 minutes
I'm a little worried that recent R PRs introduced a Mac installation performance problem, but I've also found (across many projects, not just LightGBM), that the Mac environments on Travis are not as reliable as the Linux environments.
Either way, that investigation can come later...this PR should unblock us.