[ci] Move R Windows CI to GitHub Actions#3168
Merged
jameslamb merged 4 commits intomicrosoft:masterfrom Jun 22, 2020
Merged
Conversation
StrikerRUS
approved these changes
Jun 16, 2020
Collaborator
There was a problem hiding this comment.
@jameslamb Wow! Surprised how fast you've got it work! You are truly magician!
Is everything OK with return code from Run-R-Code-Redirect-Stderr?
Just some minor comments:
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
guolinke
approved these changes
Jun 20, 2020
Collaborator
|
@jameslamb Very strange error at master |
Collaborator
Author
|
😱 I have never seen that one! |
This was referenced Jun 23, 2020
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #3065 (review), moving all Windows R CI jobs to GitHub Actions.
Why this is important
This should reduce the total runtime of CI for this project. GitHub Actions allows 20 concurrent builds...AppVeyor (which we currently use) allows 1 😬
While testing on my fork, I found that thanks to this concurrency, all 12 jobs for R run in 12-13 minutes!!!
As of this PR, we will have four R Windows jobs all in GitHub Actions:
MSYS2toolchainMINGWtoolchainYou can see the full details of software versions for the GitHub Actions environments here.
What I Changed
We didn't move R jobs into GitHub Actions in #3119 because of the issues with Powershell jobs on GitHub Actions (https://github.community/t/powershell-steps-fail-nondeterministically/115496) / Powershell itself (PowerShell/PowerShell#12823).
R,Rscript, andinitexmfall produce harmless messages tostderr, which could trigger the issues linked above. I tried many approaches to fix this, including:$null$ErrorActionPreference = "SilentlyContinue"-ErrorActionflagOut-Nullwith|Out-Stringwith|None of these approaches worked, but the one in this PR did: calling these commands with
Rand using R's built-in redirection,sink().