Load initial scores with binary data files in CLI version#4807
Merged
StrikerRUS merged 2 commits intomicrosoft:masterfrom Mar 26, 2022
Merged
Load initial scores with binary data files in CLI version#4807StrikerRUS merged 2 commits intomicrosoft:masterfrom
StrikerRUS merged 2 commits intomicrosoft:masterfrom
Conversation
shiyu1994
requested review from
StrikerRUS,
btrotta,
chivee,
guolinke,
hzy46,
jameslamb and
tongwu-sh
as code owners
shiyu1994
changed the title
Collaborator
|
@guolinke Could you please help to review this PR? |
guolinke
approved these changes
Mar 24, 2022
40 tasks
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix #4786. Currently there's no way to load initial score when loading from binary data file in CLI version.
In
Metadata::LoadFromMemoryandMetadata::SaveBinaryToFile, other fields ofMetadatais handled, exceptinit_score_. The only way to set initial score when loading from binary data files is the call methods likeset_init_scorein Python, which is impossible for CLI version.The implementation goes like this: after loading from binary data files, checks whether there are initial score files exists. If so, initial scores are loaded.
The corresponding documentation for continual training is also updated.