Add C API function that returns all parameter names with their aliases#4829
Add C API function that returns all parameter names with their aliases#4829
Conversation
StrikerRUS
changed the title
StrikerRUS
changed the title
|
OK, I believe this PR is ready for reviews. |
StrikerRUS
requested review from
Laurae2,
btrotta,
chivee,
guolinke,
henry0312,
hzy46,
jameslamb,
shiyu1994 and
tongwu-sh
as code owners
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
This is awesome! I totally support this addition to the API. I think it'll help to avoid some maintenance burden in language wrappers and will eliminate some possible bugs. Great work 🤩
Please see a few small comments I left.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
|
@jameslamb Thanks a lot for your review comments! I think I've addressed them all in the latest commit. Please take another look when have time. |
|
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Looks great, thanks for the changes, especially the new R test!
Since this touched lightgbm_R.cpp, I just did a valgrind run (sorry for not thinking of that sooner). #4829 (comment)
As soon as that passes, I'm comfortable with merging this.
|
@shiyu1994 do you support this addition to |
shiyu1994
left a comment
shiyu1994
left a comment
There was a problem hiding this comment.
@StrikerRUS @jameslamb Thank you for working on this! I've checked the C API, and the changes LGTM.
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
3 participants
Fixed #2633