[R-package] minor improvements on weight demo#5212
Merged
jameslamb merged 1 commit intomicrosoft:masterfrom May 17, 2022
Merged
[R-package] minor improvements on weight demo#5212jameslamb merged 1 commit intomicrosoft:masterfrom
jameslamb merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
jameslamb
approved these changes
May 16, 2022
Collaborator
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for doing this! I agree with @StrikerRUS 's suggestion to consider converting this demo to a vignette, but I also think we should just merge this and that that can be a separate PR if you have time / interest.
Collaborator
Author
Collaborator
|
Thank you! Totally agree with that approach @jmoralez |
40 tasks
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some extra lines that aren't necessary after #5204 and makes minor modifications to the weight descriptions.