Conversation
jameslamb
commented
Jan 28, 2023
Collaborator
Author
guolinke
reviewed
Feb 16, 2023
guolinke
approved these changes
Feb 17, 2023
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes using the C++17 standard in the CRAN build of the R package.
Motivation
CRAN recently started raising the following NOTE on r-devel.
(https://cran.r-project.org/web/checks/check_results_lightgbm.html)
That check just made it into R about 2 days ago (commit link), in preparation for C++17 becoming the default C++ standard in R's next release, v4.3.0.
So I expect that CRAN is going to ask us to make this change soon.
Implications of this change
If this PR is accepted,
src/,include/andexternal_libs/std::auto_ptrandstd::random_shuffle(docs)gcc >= 5(October 2017, supporting docs)clang >= 5(September 2017, supporting docs)MSVC >= 2019(April 2019, supporting docs)nvccin CUDA 11+ (May 2020, supporting docs)