Fix updates in random forest model using GOSS data sample strategy#6017
Merged
jameslamb merged 11 commits intomicrosoft:masterfrom Sep 5, 2023
Merged
Fix updates in random forest model using GOSS data sample strategy#6017jameslamb merged 11 commits intomicrosoft:masterfrom
jameslamb merged 11 commits intomicrosoft:masterfrom
Conversation
1) Value of data_sample_strategy was not written out in Config::SaveMembersToString() 2) GOSSStrategy->Bagging may modify value of bag_data_cnt_ during training, which may mean tmp_grad_ and tmp_hess_ need resizing in RF::TrainOneIter
jameslamb
requested changes
Aug 15, 2023
This is required by LightGBMNet
guolinke
approved these changes
Aug 18, 2023
Contributor
Author
|
@jameslamb Are we ready to merge this now please? |
Collaborator
I've just merged In the future, you can reduce the time it takes to get changes reviewed and merged here by doing the following in pull requests:
Thanks as always for your help with LightGBM! |
jameslamb
approved these changes
Sep 4, 2023
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1) Value of data_sample_strategy was not written out in Config::SaveMembersToString()2) GOSSStrategy->Bagging may modify value of bag_data_cnt_ during training, which may mean tmp_grad_ and tmp_hess_ need resizing in RF::TrainOneIter. Without this change, an exception is thrown during training at line 138 of rf.hpp.