Conversation
This was referenced Sep 4, 2023
Collaborator
Author
|
@guolinke could you please review this when you have time? |
guolinke
approved these changes
Oct 6, 2023
Collaborator
Author
|
thank you! |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #3756.
Moves all R 4.x CI jobs to R 4.3.1 (the latest available version).
Issues this PR's changes address
On Windows (minGW)
This did not show up on R 4.2. It seems related to fmtlib/fmt#3533, and seems to have been fixed by updated
fmtin #6074.On Windows (MSVC)
Looks like this is caused by this change to
include/R_ext/Complex.hin R's headers, here: wch/r-source@fb52ac1. And from that commit, seems that the R Core team understood that this was something that not all compilers might support:Seems to be that MSVC does not like anonymous types in structs: https://stackoverflow.com/a/58571593/3986677.