Conversation
…tside of OpenMP wrapper
guolinke
approved these changes
Oct 9, 2023
Collaborator
Author
|
thanks so much for the quick reviews @guolinke ! |
Ten0
pushed a commit
to Ten0/LightGBM
that referenced
this pull request
Jan 12, 2024
…tside of OpenMP wrapper (microsoft#6133)
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #4705.
Contributes to #5987.
LightGBM uses OpenMP for to parallelize many operations via multi-threading.
It's C/C++ codebase uses some wrapper functions defined in a header file
openmp_wrapper.hto get and set the number of threads to use in such operations:LightGBM/include/LightGBM/utils/openmp_wrapper.h
Lines 20 to 35 in f901f47
There are a few places in the code which bypass those helpers and instead directly call
omp_get_num_threads()andomp_get_max_threads().This PR proposes switching such calls to instead use LightGBM's wrappers. That reduces the number of different code paths that multi-threading configuration goes through, therefore reducing the risk of configuration inconsistencies and issues like #4705 and #5124.